Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISEB to building catalogue #1097

Closed
wants to merge 9 commits into from
Closed

Add ISEB to building catalogue #1097

wants to merge 9 commits into from

Conversation

vinnyho
Copy link
Contributor

@vinnyho vinnyho commented Jan 1, 2025

Summary

  • Added ISEB to building catalogue.
  • Used Google Maps for coordinates.

Test Plan

  • Tested with custom event creation.
  • Tested on map.

Images

Issues

Closes #1085

@MinhxNguyen7 MinhxNguyen7 self-requested a review January 6, 2025 20:07
@MinhxNguyen7 MinhxNguyen7 self-assigned this Jan 6, 2025
MinhxNguyen7
MinhxNguyen7 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it would be nice to have an image for it.

@vinnyho vinnyho closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 MinhxNguyen7 approved these changes

Assignees

@MinhxNguyen7 MinhxNguyen7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ISEB is not included in buildingCatalogue.ts
2 participants
@vinnyho @MinhxNguyen7